Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crud-web-apps/jupyter): dict variable reference for node.status.capacity #7485

Conversation

mishraprafful
Copy link
Contributor

Related Issues/PRs

Fixes #7441

Changes

  • Corrected node status reference
  • Converted string to f-string

Comments

Previous known working version

installed_resources.update(node.status.capacity.keys())

Signed-off-by: mishraprafful <mishraprafful@gmail.com>
@mishraprafful mishraprafful changed the title fix: dict variable reference for node.status.capacity fix(crud-web-apps/jupyter): dict variable reference for node.status.capacity Feb 22, 2024
@mishraprafful
Copy link
Contributor Author

@thesuperzapper As per our conversation on the community call, I did confirm that there were no other issues on the PR that caused this issue. So we should be all good 👍🏻

@thesuperzapper
Copy link
Member

@mishraprafful thanks!

Discussed in Notebooks WG meeting.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bd7f250 into kubeflow:master Mar 14, 2024
7 checks passed
@mishraprafful mishraprafful deleted the fix/jupyter-webapp-node-capacity branch March 14, 2024 15:44
@thesuperzapper thesuperzapper added this to the v1.9.0 milestone May 9, 2024
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…capacity` (kubeflow/kubeflow#7485)

Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…capacity` (kubeflow/kubeflow#7485)

Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…capacity` (kubeflow/kubeflow#7485)

Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
…capacity` (kubeflow/kubeflow#7485)

Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
…capacity` (kubeflow/kubeflow#7485)

Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create notebooks page and get [500] error
2 participants