fix(crud-web-apps/jupyter): dict variable reference for node.status.capacity
#7485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mishraprafful <mishraprafful@gmail.com>
mishraprafful
changed the title
node.status.capacitynode.status.capacity
|
@thesuperzapper As per our conversation on the community call, I did confirm that there were no other issues on the PR that caused this issue. So we should be all good 👍🏻 |
|
@mishraprafful thanks! Discussed in Notebooks WG meeting. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Fixes #7441
Changes
Comments
Previous known working version
kubeflow/components/crud-web-apps/jupyter/backend/apps/common/routes/get.py
Line 117 in 0c0c763