-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crud-web-apps/jupyter): dict variable reference for node.status.capacity
#7485
fix(crud-web-apps/jupyter): dict variable reference for node.status.capacity
#7485
Conversation
Signed-off-by: mishraprafful <mishraprafful@gmail.com>
node.status.capacity
node.status.capacity
@thesuperzapper As per our conversation on the community call, I did confirm that there were no other issues on the PR that caused this issue. So we should be all good 👍🏻 |
@mishraprafful thanks! Discussed in Notebooks WG meeting. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
…capacity` (kubeflow/kubeflow#7485) Signed-off-by: mishraprafful <mishraprafful@gmail.com>
Related Issues/PRs
Fixes #7441
Changes
Comments
Previous known working version
kubeflow/components/crud-web-apps/jupyter/backend/apps/common/routes/get.py
Line 117 in 0c0c763