Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KServe and Kubeflow 1.5 release #2110

Closed
kimwnasptd opened this issue Jan 24, 2022 · 9 comments
Closed

KServe and Kubeflow 1.5 release #2110

kimwnasptd opened this issue Jan 24, 2022 · 9 comments

Comments

@kimwnasptd
Copy link
Member

@yuzisun @animeshsingh @pvaneck starting this tracking issue to coordinate the integration of KServe with the Kubeflow 1.5 release.

First off a heads up that the feature freeze phase will start Tuesday (25th January). Before then I'd like to have updated this repo with the manifests of the kserve/kserve repo, in order to be able to cut the first RC tag in this repo.

From Paul's Community presentation I understand we are targeting KServe 0.7 and the corresponding git tag.

We will also target Knative 0.22 and K8s 1.20 for the KF 1.5 release. Do the above sound good to you as well? I'll also take care of including the models web app as well, now that it has its own repo

cc @kubeflow/release-team

@kubeflow-bot kubeflow-bot added this to To Do in Needs Triage Jan 24, 2022
@kimwnasptd kimwnasptd added this to Tracking in v1.5 Release Jan 24, 2022
@pvaneck
Copy link
Member

pvaneck commented Jan 25, 2022

Thanks, @kimwnasptd. I think that sounds good, though I wonder if a newer Knative Version would be preferred (e.g. v0.26). @yuzisun Do you have thoughts on the Knative version, or is 0.22.1 (the current version being used) still fine?

@kimwnasptd
Copy link
Member Author

Small update from my side regarding the models web app and the manifests:

  1. I'm pushing on versioning the models web app, to include it in the manifests as well. Having issues with prow Versioning of the app kserve/models-web-app#26 Update the manifests for KF release kserve/models-web-app#27
  2. I'm going to keep both the current KFServing manifests and the KServe ones in the repo

Since this will be a transitioning release we discussed with the rest of the @kubeflow/wg-manifests-leads that it would be a good idea to keep both existing KFServing 0.6.1 manifests and include KServe 0.7. This way users will have the option to stick to 0.6.1, if they are not ready to move to KServe right now.

But at the same time we will also try to highlight the migration script for people to start transitioning to KServe https://github.com/kserve/kserve/tree/master/hack/kserve_migration.

@yuzisun @pvaneck I'm guessing that this is the correct script right? Is there any other documentation someplace else for migrating from KFServing CRDs to KServe's?

@Tomcli
Copy link
Member

Tomcli commented Feb 4, 2022

It looks like Knative v0.22.1 might have some mutation errors on Kubernetes v1.22. I was digging into the release comments and some of the Kubernetes 1.22 fixes are patched in Knative 0.22.3. It is possible to upgrade the knative version?
https://github.com/knative/serving/releases/tag/v0.22.3

@kimwnasptd
Copy link
Member Author

Thanks for the heads up @Tomcli!

It looks like Knative v0.22.1 might have some mutation errors on Kubernetes v1.22

Can you also point some of the opened issues, so that users can be aware of them as well?

It is possible to upgrade the knative version?

Considering that we are targeting K8s 1.20 and 1.21 for the KF 1.5 release, I'll put a slightly less priority in this update. But, since it's a very small bump I'll get to it once I complete the basic tests in manifests which will also help evaluating quickly such small updates #2099

@Tomcli
Copy link
Member

Tomcli commented Feb 7, 2022

Here's the issue on k8s 1.22+
knative/serving#11448

The new minor release is to address the new APIs in k8s 1.22+

@yhwang
Copy link
Member

yhwang commented Feb 9, 2022

@kimwnasptd are you going to provide kustomization.yaml under contrib/kserve and also the corresponding models web app under that folder for kubeflow 1.5?

@kimwnasptd
Copy link
Member Author

@kimwnasptd are you going to provide kustomization.yaml under contrib/kserve and also the corresponding models web app under that folder for kubeflow 1.5?

@yhwang correct, I'm working on getting the versioning of the app done kserve/models-web-app#26 and then including the 0.7 version of the app in the contrib/kserve folder as well.

@juliusvonkohout
Copy link
Member

/close

There has been no activity for a long time. Please reopen if necessary.

@google-oss-prow
Copy link

@juliusvonkohout: Closing this issue.

In response to this:

/close

There has been no activity for a long time. Please reopen if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Needs Triage automation moved this from To Do to Closed Aug 24, 2023
@kubeflow-bot kubeflow-bot removed this from Closed in Needs Triage Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

5 participants