Make the KFDef stacks example non GCP specifc. #1238
Conversation
* For GCP will not be using KFDef with 1.1; instead we will be using blueprints (see kubeflow#1063) * Therefore I updated the existing example of deploying using stacks to make it non GCP specific so that it could be used as an example for platforms that still want to use KFDef. * kubeflow#1062 is tracking migrating all KFDefs to the new versions of our kustomize packages
|
This change is |
|
/assign @yanniszark @yanniszark @animeshsingh @Jeffwan who wants to review this? |
| path: istio/gcp-1-1-6 | ||
| name: istio-stack | ||
| # TODO: If you actually want to install ISTIO as part of KFDef setup you would | ||
| # need to add the appropriate package. |
There was a problem hiding this comment.
Q: Which istio version should application authors expect? I know for GCP it's 1.4+ (from memory, not sure if accurate). Did we upgrade from 1.1 for others, is there a plan?
e.g. KFP multi user mode will ideally use new authorization CRDs introduced after 1.2, it would make others not compatible
There was a problem hiding this comment.
I don't think we have published any requirements about minimum or maximum supported ISTIO versions. So right now I would say its up to each individual application owner to decide which versions of ISTIO to be compatible with.
|
/lgtm |
|
@jlewi: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For GCP will not be using KFDef with 1.1; instead we will be using
blueprints (see GCP KFDef's should follow kustomize v3 patterns #1063)
Therefore I updated the existing example of deploying using stacks
to make it non GCP specific so that it could be used as an example
for platforms that still want to use KFDef.
of our kustomize packages