feat: remove outdated metadata UI manifests

[Bobgy]

Which issue is resolved by this Pull Request:
Resolves kubeflow/metadata#250

Checklist:

• Unit tests have been rebuilt:
  1. cd manifests/tests
  2. make generate-changed-only
  3. make test

[Bobgy]

/assign @PatrickXYS @Jeffwan @jlewi

[k8s-ci-robot]

@Bobgy: GitHub didn't allow me to assign the following users: jlewi.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @PatrickXYS @Jeffwan @jlewi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[PatrickXYS]

/test kubeflow-manifests-presubmit-e2e

[k8s-ci-robot]

@PatrickXYS: No presubmit jobs available for kubeflow/manifests@master

In response to this:

/test kubeflow-manifests-presubmit-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Jeffwan]

This is for metadata-service not ui-service.?

[Bobgy]

The obj reference targets UI service, and I removed its usage.

Do we still need to keep metadata server?
If yes, how do people access it? And how do people access it before? Was the UI service a proxy to the server?

@Jeffwan @zhenghuiwang

[Jeffwan]

We discuss this in another thread. I think we all agree to remove this. kubeflow/metadata#250

[Bobgy]

Reply

[PatrickXYS]

The reason that E2E tests failed is

https://github.com/kubeflow/kfctl/blob/master/py/kubeflow/kfctl/testing/pytests/kf_is_ready_test.py#L86-L98

def test_metadata_is_ready(record_xml_attribute, namespace, cluster_name):
    deployment_names = [
        "metadata-deployment",
        "metadata-grpc-deployment",
        "metadata-db",
        "metadata-ui",
        "metadata-envoy-deployment",
        "metadata-writer",
    ]
    check_deployments_ready(record_xml_attribute, namespace,
                            "test_metadata_is_ready", deployment_names,
                            cluster_name)

Since this PR deleted metadata-ui, which breaks E2E tests, should send a PR to change E2E as well

[PatrickXYS]

/retest

[Jeffwan]

We discuss this in another thread. I think we all agree to remove this. kubeflow/metadata#250

[Jeffwan]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• metadata/OWNERS [Bobgy]
• stacks/ibm/OWNERS [Bobgy]
• tests/OWNERS [Bobgy,Jeffwan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Jeffwan]

Thanks @Bobgy driving the work

[PatrickXYS]

@Bobgy Will this change go into v1.2-branch? If so, we may need cherry-pick this PR as well kubeflow/kfctl#440

[Bobgy]

Yes, I'll cherry pick it

[PatrickXYS]

For this PR kubeflow/kfctl#440, @pvaneck helped cherry-pick in this PR kubeflow/kfctl#441

So you should be good to only pick current PR #1619