Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick AWS PR #1629 #1630 #1631

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

PatrickXYS
Copy link
Member

@PatrickXYS PatrickXYS commented Nov 10, 2020

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Cherry-pick merged PRs from master to v1.2-branch

  1. Presubmit kicked off by istio_dex manifests #1630
  2. Remove Tensorboard for AWS 1.2 Manifests #1629

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@PatrickXYS PatrickXYS changed the title Remove Tensorboard for AWS 1.2 Manifests (#1629) Cherry-Pick: Remove Tensorboard for AWS 1.2 Manifests (#1629) Nov 10, 2020
@PatrickXYS
Copy link
Member Author

/cc @Jeffwan

@PatrickXYS
Copy link
Member Author

/cc @Jeffwan

@PatrickXYS PatrickXYS changed the title Cherry-Pick: Remove Tensorboard for AWS 1.2 Manifests (#1629) Cherry-Pick AWS PR #1629 #1630 Nov 11, 2020
@Jeffwan
Copy link
Member

Jeffwan commented Nov 11, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2730201 into kubeflow:v1.2-branch Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants