Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mysql deployment strategy (#1562) #1643

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

thesuperzapper
Copy link
Member

(cherry picked from commit 6c4f265)

See PR:#1562

@thesuperzapper
Copy link
Member Author

@PatrickXYS can you review?

@PatrickXYS
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatrickXYS, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickXYS
Copy link
Member

===== ACTUAL END ==========================================
  EXPECTED                                                                                 ACTUAL
  --------                                                                                 ------
  apiVersion: apps/v1                                                                      apiVersion: apps/v1
  kind: Deployment                                                                         kind: Deployment
  metadata:                                                                                metadata:
    labels:                                                                                  labels:
      app: katib                                                                               app: katib
      app.kubernetes.io/component: katib                                                       app.kubernetes.io/component: katib
      app.kubernetes.io/name: katib-controller                                                 app.kubernetes.io/name: katib-controller
      component: mysql                                                                         component: mysql
    name: katib-mysql                                                                        name: katib-mysql
    namespace: kubeflow                                                                      namespace: kubeflow
  spec:                                                                                    spec:
    replicas: 1                                                                              replicas: 1
    selector:                                                                                selector:
      matchLabels:                                                                             matchLabels:
        app: katib                                                                               app: katib
        app.kubernetes.io/component: katib                                                       app.kubernetes.io/component: katib
        app.kubernetes.io/name: katib-controller                                                 app.kubernetes.io/name: katib-controller
        component: mysql                                                                         component: mysql
X    template:                                                                                strategy:
X      metadata:                                                                                type: Recreate
X        annotations:                                                                         template:
X          sidecar.istio.io/inject: "false"                                                     metadata:
X        labels:                                                                                  annotations:
X          app: katib                                                                               sidecar.istio.io/inject: "false"
X          app.kubernetes.io/component: katib                                                     labels:
X          app.kubernetes.io/name: katib-controller                                                 app: katib

Unit test failed, can you regenerate tests? @thesuperzapper

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 16, 2020
@PatrickXYS
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit fc9fe83 into kubeflow:v1.2-branch Nov 16, 2020
@thesuperzapper thesuperzapper deleted the 1.2-branch branch December 6, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants