Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure v1.2 Manifests: Fix namespaces for Knative and KFServing #1698

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Azure v1.2 Manifests: Fix namespaces for Knative and KFServing #1698

merged 2 commits into from
Dec 15, 2020

Conversation

berndverst
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#5452

Description of your changes:
Moves KFServing and Knative into KFDef to support deployment to appropriate namespaces instead of the default Kubeflow namespace.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@PatrickXYS
Copy link
Member

/lgtm
/approve

I would encourage you find 2nd reviewer of Azure changes if possible @berndverst

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: berndverst, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b64b76b into kubeflow:v1.2-branch Dec 15, 2020
@berndverst
Copy link
Member Author

Thanks @PatrickXYS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants