Use hashFromEnv in dex component for static user passwords

[mvoitko]

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Checklist:

• Unit tests pass:
  Make sure you have installed kustomize == 3.2.1
  1. make generate-changed-only
  2. make test

[mvoitko]

@krishnadurai could you please review?

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishnadurai, mvoitko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• common/dex/OWNERS [krishnadurai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mvoitko]

@krishnadurai @yanniszark Could you please add the lgtm label so I merge the PR?

[umka1332]

Hi @mvoitko, can you please explain the purpose of this change.

[mvoitko]

@umka1332 The goal is to be a little bit more secure and not to store passwords in plain text in the source code. Also there was a comment

[juliusvonkohout]

Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion

[mvoitko]

Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion

I'm sorry, I don't know how to do this. Could you please help with the link to the agenda and the meeting?

[juliusvonkohout]

Yes of course. https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars here you can find all community meetings and join slack and the channel manifests-wg as well. In the calendar entry you can also find the meeting notes on google documents.

[juliusvonkohout]

/lgtm

and the owner @krishnadurai approved

[kromanow94]

This PR made Kubeflow not usable through WEB UI because of auth misconfiguration.

@mvoitko can you fix those two simple issues?

[kromanow94]

This value should be encrypted with base64 or provided as stringData.DEX_USER_PASSWORD.

Using this in current form presents this error on kubectl apply:

Error from server (BadRequest): error when creating "STDIN": Secret in version "v1" cannot be handled as a Secret: illegal base64 data at input byte 52

[kromanow94]

This file is not added to kustomization.yaml in resources section. Installing Kubeflow with this version renders dex as CreateContainerConfigError:

$ kubectl  -n auth describe pod -l app=dex
(...)
Events:
  Type     Reason     Age                From               Message
  ----     ------     ----               ----               -------
  Normal   Scheduled  39s                default-scheduler  Successfully assigned auth/dex-86f655645d-qc92d to kind-worker2
  Normal   Pulled     11s (x4 over 38s)  kubelet            Container image "ghcr.io/dexidp/dex:v2.36.0" already present on machine
  Warning  Failed     11s (x4 over 38s)  kubelet            Error: secret "dex-passwords" not found

[juliusvonkohout]

@kromanow94 you can also create a PR and I can approve :-) this here was approved by a probably stale owner @krishnadurai by accident then.