Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kustomization.yaml - update tag and repo #2474

Closed
wants to merge 1 commit into from

Conversation

ralfluebben
Copy link

The given image does not work in KF, this commit updates it from gcr.io/arrikto/kubeflow/oidc-authservice:e236439 to gcr.io/arrikto/oidc-authservice:0c4ea9a , note that registry link and tag is updated.

fixes #2423

Which issue is resolved by this Pull Request:
Resolves #2423

Description of your changes:
Update of oidc-authservice image from gcr.io/arrikto/kubeflow/oidc-authservice:e236439 to gcr.io/arrikto/oidc-authservice:0c4ea9a as described in issue #2423

The given image does not work in KF, this commit updates it from gcr.io/arrikto/kubeflow/oidc-authservice:e236439 to gcr.io/arrikto/oidc-authservice:0c4ea9a , note that registry link and tag is updated.

fixes kubeflow#2423
@google-cla
Copy link

google-cla bot commented Jul 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ralfluebben
Once this PR has been reviewed and has the lgtm label, please assign patrickxys for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@annajung
Copy link
Member

annajung commented Jul 7, 2023

hi @ralfluebben, could you please sign the CLA for the PR to be reviewed? Only the PRs with CLA assigned are typically reviewed by the WG, thanks!

cc @kimwnasptd to review the changes

@ralfluebben
Copy link
Author

@annajung Thanks, I forgot to rescan the pull request, should be fine now.

@juliusvonkohout
Copy link
Member

Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion

@juliusvonkohout
Copy link
Member

/close

there has been no response since august 25 and we are dropping the oidc-authservice anyway in 1.9 see #2544

Copy link

@juliusvonkohout: Closed this PR.

In response to this:

/close

there has been no response since august 25 and we are dropping the oidc-authservice anyway in 1.9 see #2544

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oidc-authservice: infinite redirect loop with v1.7.0-rc.2
3 participants