-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the kubeflow-m2m-oidc-configurator a CronJob #2667
Merged
google-oss-prow
merged 7 commits into
kubeflow:master
from
kromanow94:make-the-oidc-configurator-a-cronjob
Jun 21, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8ecf549
Make the kubeflow-m2m-oidc-configurator a CronJob
kromanow94 9fcf494
cronjob.kubeflow-m2m-oidc-configurator: concurrencyPolicy: Forbid
kromanow94 5c2157b
add tests/gh-actions/wait_for_kubeflow_m2m_oidc_configurator.sh
kromanow94 442bc77
Improve wait routine for m2m oidc configurator (#2)
kromanow94 2af863d
use docker.io/curlimages/curl for cronjob.kubeflow-m2m-oidc-configura…
kromanow94 8d54066
make the m2m oidc configurator idempotent
kromanow94 c830a7a
verify jwks configuration in requestauthentication
kromanow94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
.../configure-self-signed-kubernetes-oidc-issuer/cronjob.kubeflow-m2m-oidc-configurator.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
apiVersion: batch/v1 | ||
kind: CronJob | ||
metadata: | ||
name: kubeflow-m2m-oidc-configurator | ||
namespace: istio-system | ||
spec: | ||
schedule: '*/5 * * * *' | ||
concurrencyPolicy: Forbid | ||
jobTemplate: | ||
spec: | ||
backoffLimit: 3 | ||
ttlSecondsAfterFinished: 600 | ||
template: | ||
metadata: | ||
labels: {} | ||
spec: | ||
restartPolicy: OnFailure | ||
serviceAccountName: kubeflow-m2m-oidc-configurator | ||
containers: | ||
- image: docker.io/curlimages/curl | ||
name: kubeflow-m2m-oidc-configurator | ||
command: | ||
- /script.sh | ||
envFrom: | ||
- configMapRef: | ||
name: kubeflow-m2m-oidc-configurator-envs | ||
volumeMounts: | ||
- mountPath: /script.sh | ||
name: script | ||
subPath: script.sh | ||
resources: {} | ||
volumes: | ||
- name: script | ||
configMap: | ||
name: kubeflow-m2m-oidc-configurator-script | ||
defaultMode: 0777 | ||
items: | ||
- key: script.sh | ||
path: script.sh | ||
34 changes: 0 additions & 34 deletions
34
...netes-oidc-issuer/job.configure-kubernetes-oidc-issuer-jwks-in-requestauthentication.yaml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure that script.sh is idempotent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, well it doesn't verify if the JWKS is present and after all is always performing the patch so this might be an improvement. I think the JWKS value should be also compared and only patched if different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made changes so the script will first check for the JWKS present in RequestAuthentication and only patch if not equal to the desired JWKS.