Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also use hashFromEnv for oauth2-proxy overlay #2669

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

codablock
Copy link
Contributor

Description of your changes:
Same as cd991e6

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 5.2.1+
    1. make generate-changed-only
    2. make test

Same as cd991e6

Signed-off-by: Alexander Block <ablock84@gmail.com>
@kromanow94
Copy link
Contributor

I deployed this on kind + WSL on my local environment. I confirm the dex is working properly.

Thanks for taking care of this.

@juliusvonkohout
Copy link
Member

/hold

CC @diegolovison since we might need to update the main readme.md documentation.

@diegolovison
Copy link
Contributor

Hi. I am not familiar with that code change. In the readme there are 3 entries with 12341234

What exactly this code is changing?

@kromanow94
Copy link
Contributor

@diegolovison it's about referencing the same value from env instead of providing as plaintext. It's more secure. Please see:

common/dex/base/dex-passwords.yaml

@diegolovison
Copy link
Contributor

diegolovison commented Apr 8, 2024

The values are matching. I believe we don't need to change the readme

@juliusvonkohout
Copy link
Member

cd991e6 helped a lot with the decision :-D

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codablock, juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

/unhold

@google-oss-prow google-oss-prow bot merged commit 7652d2f into kubeflow:master Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants