Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bentoml to 1.2.28 and 1.1.21 #2704

Merged
merged 2 commits into from
May 7, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented May 7, 2024

Which issue is resolved by this Pull Request:
As suggested #2693 (comment) I am proposing to update betnoml manifests

Description of your changes:

Following the UPGRADE.md instructions I updated contrib/bentoml with the latest version content.

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 5.2.1+
    1. make generate-changed-only
    2. make test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
@lampajr
Copy link
Member Author

lampajr commented May 7, 2024

Locally I am experiencing a failure running bentoml tests, in particular while issueing the curl to the fraud-detection pod. From the logs I see:

2024-05-07T08:38:31+0000 [ERROR] [api_server:1] Exception on /is_fraud [POST] (trace=fe8f5861ac58e7997bf04620e99e67ba,span=62350ba5fd974236,sampled=0)
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/bentoml/_internal/server/http_app.py", line 324, in api_func
    output = await api.func(input_data)
  File "/home/bentoml/bento/src/service.py", line 34, in is_fraud
    results = await asyncio.gather(*[_is_fraud(p, r, input_df) for p, r in zip(fraud_detection_preprocessors, fraud_detection_runners)])
  File "/home/bentoml/bento/src/service.py", line 28, in _is_fraud
    input_features = preprocessor.transform(input_df)
  File "/usr/local/lib/python3.10/site-packages/sklearn/utils/_set_output.py", line 140, in wrapped
    data_to_wrap = f(self, X, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 800, in transform
    Xs = self._fit_transform(
  File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 652, in _fit_transform
    transformers = list(
  File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 349, in _iter
    transformers = [
  File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 350, in <listcomp>
    replace_passthrough(*trans) for trans in self.transformers_
  File "/usr/local/lib/python3.10/site-packages/sklearn/compose/_column_transformer.py", line 345, in replace_passthrough
    if name not in self._name_to_fitted_passthrough:
AttributeError: 'ColumnTransformer' object has no attribute '_name_to_fitted_passthrough'

@juliusvonkohout any idea?

Anyway, let's see if the same error happens here in the GHA

@juliusvonkohout
Copy link
Member

juliusvonkohout commented May 7, 2024

@yubozhao you need to maintain bentoml or we need to consider removing it from Kubeflow

@juliusvonkohout
Copy link
Member

Maybe we need to upgrade from https://github.com/bentoml/Fraud-Detection-Model-Serving

@juliusvonkohout
Copy link
Member

In the worst case you have to drop some test parts until it is working again. This is fine for /contrib stuff.

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
@lampajr
Copy link
Member Author

lampajr commented May 7, 2024

Maybe we need to upgrade from https://github.com/bentoml/Fraud-Detection-Model-Serving

Yeah, maybe yes as it looks like it is using docker.io/bentoml/fraud_detection:o5smnagbncigycvj and from https://github.com/bentoml/Fraud-Detection-Model-Serving I don't see any change since last year

In the worst case you have to drop some test parts until it is working again. This is fine for /contrib stuff.

If this is acceptable, I think it is enough to skip the curl request.. all other checks should work. See deaf47b

@juliusvonkohout juliusvonkohout marked this pull request as ready for review May 7, 2024 14:51
@juliusvonkohout
Copy link
Member

This is just /contrib which shall not block the release, so

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, lampajr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot merged commit 246e1f2 into kubeflow:master May 7, 2024
4 checks passed
@lampajr lampajr deleted the upgrade_bentoml branch May 7, 2024 15:11
juliusvonkohout pushed a commit that referenced this pull request May 13, 2024
* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
google-oss-prow bot pushed a commit that referenced this pull request May 13, 2024
* Fix kserve upgrade script and update kserve diagram (#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update cert-manager to 1.14.5 (#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Refactor test workflows  (#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme (#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade knative to v1.12.4 (#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
google-oss-prow bot pushed a commit that referenced this pull request May 13, 2024
* Fix kserve upgrade script and update kserve diagram (#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* update cert-manager to 1.14.5 (#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Refactor test workflows  (#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* update readme (#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Upgrade knative to v1.12.4 (#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Fixes for dco changes (#2713)

* Fix kserve upgrade script and update kserve diagram (#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update cert-manager to 1.14.5 (#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Refactor test workflows  (#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme (#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade knative to v1.12.4 (#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update cert-manager to 1.14.5 (kubeflow#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Refactor test workflows  (kubeflow#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme (kubeflow#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (kubeflow#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade knative to v1.12.4 (kubeflow#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants