test_harness w/ fixes for the unit tests to pass #50
Conversation
|
/assign @hougangliu |
|
/assign @jlewi |
|
/assign @swiftdiaries |
README.md
Outdated
| ``` | ||
|
|
||
| ## Kfctl Processing | ||
| Kfctl will traverse these directories to find and build kustomize targets based on the configuration file `app.yaml`. App.yaml is derived from a file in the kubeflow [config](https://github.com/kubeflow/kubeflow/tree/master/bootstrap/config) directory. Each target processed by kfctl will result in an output yaml file. The output file is generated by calling kustomize's API. The kustomize package manager in kfctl will read app.yaml and apply the packages, components and componentParams to kustomize in the following way: | ||
| Kfctl traverses directories under manifests to find and build kustomize targets based on the configuration file `app.yaml`. App.yaml is derived from a file in the kubeflow [config](https://github.com/kubeflow/kubeflow/tree/master/bootstrap/config) directory. Each target processed by kfctl will result in an output yaml file. The output file is generated via kustomize's API. The kustomize package manager in kfctl will read app.yaml and apply the packages, components and componentParams to kustomize in the following way: |
README.md
Outdated
|
|
||
| Generating yaml output for any target can be done in the following way: | ||
| Kfctl has the capability to combine more than one overlay during `kfctl generate ...`. An example is shown below where the profiles target in [manifests](https://github.com/kkasravi/manifests/tree/multiple_overlays/profiles) can include either debug changes in the Deployment or Device information in the Namespace (the devices overlay is not fully integrated with the Profile-controller at this point in time and is intended as an example) or **both**. |
There was a problem hiding this comment.
please link manifests to https://github.com/kubeflow/manifests/tree/master/profiles
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, 2 unresolved discussions (waiting on @hougangliu, @kunmingg, and @lluunn)
README.md, line 94 at r2 (raw file):
Previously, hougangliu (Hougang Liu) wrote…
s/App.yaml/app.yaml
Done.
README.md, line 120 at r2 (raw file):
Previously, hougangliu (Hougang Liu) wrote…
please link manifests to https://github.com/kubeflow/manifests/tree/master/profiles
Done.
|
/assign @ashahba |
|
/lgtm |
|
@hougangliu @kkasravi one of you needs to approve this for it to get merged. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swiftdiaries The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #49
Provides a basic unit test generator that generates golang code for each kustomize target. The golang test cases are then compiled and run by
go test -v .makeunder testsmakefirst runs hack/gen-test-targets.sh which creates golang code that uses a local copy of kusttarget_test.gogo test -v .is calledThis change is