Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing loadBalancerScheme issue in ingress annotation #952

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fixing loadBalancerScheme issue in ingress annotation #952

merged 1 commit into from
Feb 25, 2020

Conversation

PatrickXYS
Copy link
Member

@PatrickXYS PatrickXYS commented Feb 25, 2020

Which issue is resolved by this Pull Request:
Resolves #946

Description of your changes:
Fixing loadBalancerScheme issue in ingress annotation.
loadBalancerScheme was introduced in the base manifest but there's no params.yaml for base and annotation doesn't get updated. no-auth kfctl_aws.yaml is affected. Thus, I added one params.yaml and modified kustomization.yaml file.

Checklist:

  • [Done] Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @PatrickXYS. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Member Author

/assign @Jeffwan

@PatrickXYS
Copy link
Member Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Jeffwan
Copy link
Member

Jeffwan commented Feb 25, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f248e85 into kubeflow:master Feb 25, 2020
Jeffwan added a commit to Jeffwan/manifests that referenced this pull request Feb 28, 2020
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2020
…961)

* Create overlay allowing the Load Balancer to be created with HTTPS with it handling no auth. Additionally making the scheme (internet facing/internal) configurable and adding external-dns annotation for clusters with it installed. Cleaned up some duplicated annotations as well (#653)

* Upgrade aws component version (#890)

* Upgrade aws components versions for v1.0

* Update tests for aws components

* Add policy profile controller plugin need (#917)

* Add external mysql option for pipeline and metadata (#906)

* Add OWNERS file under test folder (#947)

* Fixing loadBalancerScheme issue in ingress annotation (#952)

* Fix AWS OIDC settings (#953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadBalancerScheme is not replaced in ingress annotation
4 participants