Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Fix a typo in metadata sample notebook #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielsiwiec
Copy link

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @danielsiwiec. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bobgy
Copy link
Contributor

Bobgy commented Oct 26, 2020

/lgtm
/approve
Thank you for the fix!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bobgy, danielsiwiec
To complete the pull request process, please assign gaoning777 after the PR has been reviewed.
You can assign the PR to them by writing /assign @gaoning777 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@danielsiwiec: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-metadata-presubmit 8dbe3b2 link /test kubeflow-metadata-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Bobgy
Copy link
Contributor

Bobgy commented Oct 26, 2020

I'm sorry, this repo is pretty much in an abandoned state. We'll continue to evolve the metadata story, but may not be based on this repo. If presubmit is broken, then we won't accept any new PRs.

@danielsiwiec
Copy link
Author

/retest

@k8s-ci-robot
Copy link

@danielsiwiec: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants