Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose elastic training with horovod with mpi-operator #335

Merged
merged 1 commit into from Mar 12, 2021

Conversation

zw0610
Copy link
Member

@zw0610 zw0610 commented Mar 8, 2021

Here we propose to support Elastic Horovod on MPI Operator. For more details, please refer the markdown file committed.

@zw0610
Copy link
Member Author

zw0610 commented Mar 8, 2021

/hold pending discussion

@gaocegege
Copy link
Member

/LGTM

@andreyvelich
Copy link
Member

Thank you for doing amazing Job @zw0610!

/hold for the review.
/cc @terrytangyuan
/cc @kubeflow/wg-training-leads

@google-oss-robot google-oss-robot requested review from terrytangyuan and a team March 10, 2021 12:23
@johnugeorge
Copy link
Member

Thanks for this.
/lgtm

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall design looks great! Thanks for writing this up!

/approve
/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/lgtm

Thanks for the awesome work!

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants