Add support for Intel MPI#389
Conversation
|
cc @kawych |
|
cc @zidarko |
kawych
left a comment
kawych
left a comment
There was a problem hiding this comment.
LGTM. Would be great if you could document what Intel MPI versions was it tested with.
| func (c *MPIJobController) getOrCreateWorkersService(mpiJob *kubeflow.MPIJob) (*corev1.Service, error) { | ||
| svc, err := c.serviceLister.Services(mpiJob.Namespace).Get(mpiJob.Name + workerSuffix) | ||
| func (c *MPIJobController) getOrCreateWorkersService(job *kubeflow.MPIJob) (*corev1.Service, error) { | ||
| return c.getOrCreateService(job, newWorkersService) |
There was a problem hiding this comment.
Can you simplify the code by creating the service here and removing the newWorkersService() factory function? And same with the lanucher?
There was a problem hiding this comment.
I'm getting rid of the factory in the getOrCreateService function. But I have to keep the newWorkersService because it's used for tests.
| source $set_intel_vars | ||
| fi | ||
|
|
||
| function resolve_host() { |
There was a problem hiding this comment.
I think this still can cause issues sometimes, i.e. sometimes there is a window when the launcher is able to resolve it's own hostname, but workers are not. This happens to me usually in the second run if I schedule two runs in a row.
It should be fine though, since this is only an example
There was a problem hiding this comment.
Are you sure that was the problem?
When I only had the check for the launcher, I was getting flaky startups. Now that I have checks for all the workers as well, the job starts every time. I couldn't really debug what was going on with just the check for the launcher, as Hydra doesn't log the output of the ssh calls :(
Adds the field .spec.mpiImplementation, defaults to OpenMPI The Intel implementation requires a Service fronting the launcher.
|
Any other suggestions? |
|
LGTM 👍 |
|
/assign @terrytangyuan |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kawych, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
.spec.mpiImplementation, defaults toOpenMPIIntel MPI is very flaky at startup, as opposed to OpenMPI. In particular, it won't retry connections to workers if they are the hostnames are not resolvable. The entrypoint handles this.