Prepare for releasing v0.4.0 #544
Conversation
|
/hold |
tenzen-y
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tenzen-y
force-pushed
the
update-rlease-0.4
branch
from
dfb36ea
to
f66c056
Compare
tenzen-y
force-pushed
the
update-rlease-0.4
branch
from
f66c056
to
e3d0ce4
Compare
|
/lgtm |
|
@alculquicondor Once #545 is merged into the master branch, can we merge this PR? |
|
Let me try to upload the images first. |
Sure. |
|
Oh, conflicts are happening. |
tenzen-y
force-pushed
the
update-rlease-0.4
branch
from
e3d0ce4
to
be9a59a
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
update-rlease-0.4
branch
from
be9a59a
to
bc5dceb
Compare
Resolved. |
| @@ -17,7 +17,7 @@ REPO_PATH="github.com/kubeflow/mpi-operator" | |||
| REL_OSARCH="linux/amd64" | |||
| GitSHA=$(shell git rev-parse HEAD) | |||
| Date=$(shell date "+%Y-%m-%d %H:%M:%S") | |||
| RELEASE_VERSION?=v0.3.0 | |||
| RELEASE_VERSION?=v0.4.0 | |||
There was a problem hiding this comment.
actually, we used 0.3.0 in the tag before, as opposed to v0.3.0
There was a problem hiding this comment.
Upon confirmation, only v0.2.3 has a v prefix.
|
/lgtm we can merge this right after the release is published in github |
|
or actually, before should be good /hold cancel |
Previously (v0.3.0), we merged before cutting a new release. |
Mainly, I updated the release note.
Note: Blocked on #540 #543.
/assign @alculquicondor @terrytangyuan