-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for releasing v0.4.0 #544
Conversation
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dfb36ea
to
f66c056
Compare
f66c056
to
e3d0ce4
Compare
/lgtm |
@alculquicondor Once #545 is merged into the master branch, can we merge this PR? |
Let me try to upload the images first. |
Sure. |
Oh, conflicts are happening. |
e3d0ce4
to
be9a59a
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
be9a59a
to
bc5dceb
Compare
Resolved. |
@@ -17,7 +17,7 @@ REPO_PATH="github.com/kubeflow/mpi-operator" | |||
REL_OSARCH="linux/amd64" | |||
GitSHA=$(shell git rev-parse HEAD) | |||
Date=$(shell date "+%Y-%m-%d %H:%M:%S") | |||
RELEASE_VERSION?=v0.3.0 | |||
RELEASE_VERSION?=v0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, we used 0.3.0
in the tag before, as opposed to v0.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon confirmation, only v0.2.3
has a v
prefix.
/lgtm we can merge this right after the release is published in github |
or actually, before should be good /hold cancel |
Previously (v0.3.0), we merged before cutting a new release. |
Mainly, I updated the release note.
Note: Blocked on #540 #543.
/assign @alculquicondor @terrytangyuan