Replace original pointer methods with ptr libs #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
tenzen-y
force-pushed
the
replace-newInt32-with-ptr
branch
from
dabf607
to
a2f6c44
Compare
|
I think this just needs rebase |
tenzen-y
force-pushed
the
replace-newInt32-with-ptr
branch
from
a2f6c44
to
3c2b957
Compare
|
@alculquicondor I rebased this PR. |
|
/hold cancel |
| return &v | ||
| } | ||
|
|
||
| func NewCleanPodPolicy(policy CleanPodPolicy) *CleanPodPolicy { |
| RunPolicy: kubeflow.RunPolicy{ | ||
| CleanPodPolicy: kubeflow.NewCleanPodPolicy(kubeflow.CleanPodPolicyRunning), | ||
| CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), |
There was a problem hiding this comment.
Suggested change
| CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), | |
| CleanPodPolicy: ptr.To(kubeflow.CleanPodPolicyRunning), |
There was a problem hiding this comment.
same for others below
| RunPolicy: kubeflow.RunPolicy{ | ||
| CleanPodPolicy: kubeflow.NewCleanPodPolicy(kubeflow.CleanPodPolicyRunning), | ||
| CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), |
There was a problem hiding this comment.
Suggested change
| CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), | |
| CleanPodPolicy: ptr.To(kubeflow.CleanPodPolicyRunning), |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
replace-newInt32-with-ptr
branch
from
3c2b957
to
9380457
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the original pointer methods with ptr libs.