Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub checks have been enabled in this repo, but are not supported by Tide. #930

Closed
cjwagner opened this issue Mar 7, 2019 · 19 comments
Closed

GitHub checks have been enabled in this repo, but are not supported by Tide. #930

cjwagner opened this issue Mar 7, 2019 · 19 comments
Assignees
@IronPan
Labels
priority/p1

Comments

@cjwagner
Copy link
Member

cjwagner commented Mar 7, 2019

It appears that GitHub checks from Travis CI have been enabled in this repo. This is causing issues with merge automation because Tide does not respect GitHub checks, only GitHub status contexts and will continue to try to merge PRs that are actually unmergeable due to failing checks from Travis CI.
Please disable the GitHub checks from Travis CI ASAP to prevent merge automation from getting stuck on PRs in this repo.

#922 (comment)
#814 (comment)
@neuromage
Copy link
Contributor

@cjwagner would you know how one can disable github checks?

/cc @vicaire
/cc @IronPan
/cc @hongye-sun
/cc @yebrahim
Did we change anything in our travis CI set up recently?

@cjwagner cjwagner mentioned this issue Mar 7, 2019
Merged
@cjwagner
Copy link
Member Author

cjwagner commented Mar 7, 2019

@cjwagner would you know how one can disable github checks?

No I don't, sorry. The checks are coming from Travis CI though so presumably there is some configuration to disable them there.
As a side note, consider moving your Travis CI tests to a ProwJob.

@vicaire
Copy link
Contributor

vicaire commented Mar 8, 2019 •
edited
Loading

/cc @IronPan, @IronPan I remember that you mentioned that we could move Travis CI tests to Prow at some point. Is there any drawback?

@cjwagner
Copy link
Member Author

Ping. This is still a problem.
Tide got stuck on this PR for a short while yesterday morning: #938

@vicaire
Copy link
Contributor

vicaire commented Mar 15, 2019

Let me sync up with @IronPan tomorrow. I will follow up by Monday EOD (if not earlier)

@IronPan
Copy link
Member

IronPan commented Mar 20, 2019

The travis tests are mostly unit tests. I always encourage people to add tests to prow but there is no current plan to migrate existing travis test to prow. there is no drawback and no much benefit either. we can prioritize this if people feel strong about it.

@IronPan
Copy link
Member

IronPan commented Mar 20, 2019

also travis was running twice because our project was set up with both travis.org and travis.com. i disabled .org.

@vicaire
Copy link
Contributor

vicaire commented Mar 21, 2019

Can we close the issue?

@cjwagner
Copy link
Member Author

Can we close the issue?

Yes, I haven't seen any errors related to this recently. The problems may have been caused by the duplicate Travis CI services.
/close

Keep in mind that Tide was designed before GH checks existed so the behavior is kind of undefined.
If Tide is working for you that is great though!

@k8s-ci-robot
Copy link
Contributor

@cjwagner: Closing this issue.

In response to this:

Can we close the issue?

Yes, I haven't seen any errors related to this recently. The problems may have been caused by the duplicate Travis CI services.
/close

Keep in mind that Tide was designed before GH checks existed so the behavior is kind of undefined.
If Tide is working for you that is great though!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@cjwagner: Closing this issue.

In response to this:

Can we close the issue?

Yes, I haven't seen any errors related to this recently. The problems may have been caused by the duplicate Travis CI services.
/close

Keep in mind that Tide was designed before GH checks existed so the behavior is kind of undefined.
If Tide is working for you that is great though!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjwagner cjwagner mentioned this issue May 9, 2019
Merged
@cjwagner
Copy link
Member Author

cjwagner commented May 9, 2019

/reopen
This is happening again: #1287
https://prow.k8s.io/tide-history?repo=kubeflow%2Fpipelines&branch=master

@k8s-ci-robot
Copy link
Contributor

@cjwagner: Reopened this issue.

In response to this:

/reopen
This is happening again: #1287
https://prow.k8s.io/tide-history?repo=kubeflow%2Fpipelines&branch=master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 9, 2019
@k8s-ci-robot k8s-ci-robot reopened this May 9, 2019
@k8s-ci-robot
Copy link
Contributor

@cjwagner: Reopened this issue.

In response to this:

/reopen
This is happening again: #1287
https://prow.k8s.io/tide-history?repo=kubeflow%2Fpipelines&branch=master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjwagner cjwagner mentioned this issue Aug 6, 2019
Merged
@cjwagner cjwagner mentioned this issue Aug 21, 2019
Merged
@cjwagner
Copy link
Member Author

Ping. This is still an issue.

@cjwagner cjwagner mentioned this issue Oct 24, 2019
Merged
@cjwagner
Copy link
Member Author

Still an issue. Please address.

@cjwagner cjwagner mentioned this issue Oct 24, 2019
Merged
@cjwagner cjwagner mentioned this issue Nov 11, 2019
Closed
@BenTheElder
Copy link

ping @jlewi

@cjwagner cjwagner mentioned this issue Nov 26, 2019
Closed
@Bobgy
Copy link
Contributor

Bobgy commented Nov 26, 2019

/close
in favor of #1653

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closing this issue.

In response to this:

/close
in favor of #1653

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@dependabot
chore(deps): bump jinja2 from 2.10.1 to 2.11.3 in /images (kubeflow#930)
186771f 
Bumps [jinja2](https://github.com/pallets/jinja) from 2.10.1 to 2.11.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/master/CHANGES.rst)
- [Commits](pallets/jinja@2.10.1...2.11.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IronPan IronPan

Labels
priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@neuromage @BenTheElder @IronPan @rmgogogo @Bobgy @cjwagner @k8s-ci-robot @vicaire