Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend + SDK): Add Backend and SDK support for timeout in pod spec #10481

Merged
merged 3 commits into from Mar 5, 2024

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Feb 13, 2024

Description of your changes:
fixes #9996
Add Backend and SDK support for pod timeout (using pod spec activeDeadlineSeconds). This is the same approach defined in the Argo timeout feature.

The SDK definition of pod timeout is similar to KFP V1:

def set_timeout(self, seconds: int):
"""Configures the pipeline level timeout.
Args:
seconds: number of seconds for timeout
"""
self.timeout = seconds
return self

Checklist:

@Tomcli Tomcli changed the title feat(backend + SDK): Add Backend and SDK support for pod spec timeout feat(backend + SDK): Add Backend and SDK support for timeout in pod spec Feb 13, 2024
@Tomcli
Copy link
Member Author

Tomcli commented Feb 13, 2024

fyi @roytman
/assign @connor-mccarthy
/assign @chensun

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm for SDKs

/assign @chensun for backend changes

kubernetes_platform/python/kfp/kubernetes/timeout.py Outdated Show resolved Hide resolved
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 15, 2024
Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
@Tomcli
Copy link
Member Author

Tomcli commented Feb 16, 2024

Squashed and signed the commit for the new DCO check.

@connor-mccarthy
Copy link
Member

/lgtm for SDK

@Tomcli
Copy link
Member Author

Tomcli commented Feb 28, 2024

Will rebase this after #10496 since that PR will also cause a conflict after merge.

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Copy link

@Tomcli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 3666ac5 link false /test kubeflow-pipelines-samples-v2
kfp-kubernetes-execution-tests 3666ac5 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Mar 5, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tomcli
Copy link
Member Author

Tomcli commented Mar 5, 2024

thanks @chensun

@google-oss-prow google-oss-prow bot merged commit b734420 into kubeflow:master Mar 5, 2024
12 of 14 checks passed
@Tomcli Tomcli deleted the timeout-backend branch March 5, 2024 19:19
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…pec (kubeflow#10481)

* Add backend and sdk support for pod spec timeout

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>

* fix conflicts

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>

---------

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
rimolive pushed a commit to rimolive/data-science-pipelines that referenced this pull request Mar 28, 2024
…pec (kubeflow#10481)

* Add backend and sdk support for pod spec timeout

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>

* fix conflicts

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>

---------

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…pec (kubeflow#10481)

* Add backend and sdk support for pod spec timeout

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>

* fix conflicts

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>

---------

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Set timeouts for v2 PipelineTask
3 participants