Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend + SDK): Add backend and SDK support to use Kubernetes FieldPath as env #10496

Merged
merged 2 commits into from Mar 4, 2024

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Feb 16, 2024

Description of your changes:
fixes #10155
Add backend and SDK support to use Kubernetes FieldPath as env. This follows the Kubernetes document is set field as env variables. https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/

This feature enables users to get information about the running pod such as metadata labels/annotations without gaining extra permission.

Checklist:

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
@Tomcli
Copy link
Member Author

Tomcli commented Feb 16, 2024

/assign @connor-mccarthy
/assign @chensun

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 28, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Tomcli
Copy link
Member Author

Tomcli commented Feb 28, 2024

Thanks @chensun, I fixed the PR conflicts and it's good to go now.

@rimolive
Copy link
Member

rimolive commented Mar 4, 2024

/retest

@Tomcli
Copy link
Member Author

Tomcli commented Mar 4, 2024

Hi @rimolive, could you help review this PR and leave a lgtm. I have rebased this PR and is good to go, just need someone to double check and lgtm.

@rimolive
Copy link
Member

rimolive commented Mar 4, 2024

/lgtm

Copy link

@Tomcli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 489ce7f link false /test kubeflow-pipelines-samples-v2
kfp-kubernetes-execution-tests 489ce7f link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-prow google-oss-prow bot merged commit dd0c17d into kubeflow:master Mar 4, 2024
12 of 14 checks passed
@Tomcli Tomcli deleted the fieldpath-backend branch March 4, 2024 22:31
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…eldPath as env (kubeflow#10496)

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…eldPath as env (kubeflow#10496)

Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[backend][sdk] Cannot assign values from Kubernetes Metadata to Environment Variables in V2
4 participants