Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in TFMA component code #1094

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 6, 2019

This change is Reviewable

@neuromage
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a195b1 into kubeflow:master Apr 6, 2019
@Ark-kun Ark-kun deleted the Fixed-bug-in-TFMA-component-code branch April 6, 2019 02:23
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Rebase AIX explainer on KFServing

* Add AIXExplainer to function

* Add AIX explainer implementation

* Fix link with local reference

* aix api patch

* Add random forest predictor

* Fix link

* Update aix-explainer image version

* Clean up example readme

* Refactor rfserver and update image

* Update inferenceservice.yaml

* Update aix-explainer.yaml

* update v1beta1 spec and tests

* Refactor sample content and rework notebook

* Add newline at EOF

* generate aix SDK spec and add predictor test

* generate aix SDK spec and add predictor test

* add aix explainer build test

* add missing __init__.py

* Add explanation e2e check

* fix containerv1 spec

* rebase api spec

* fix empty uri for aix framework

* remove testing logs

* update e2e test to match with the v1beta1 controller changes

* Fix logging

* address comments on ci config

* Make aixexplainer account for asynchronous predict calls

* Fix e2e test response parsing

* updated generated hack files to align with existing format

* update samples to use v1beta1 api

* Apply suggestions from code review

Co-authored-by: Animesh Singh <singhan@us.ibm.com>

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants