Removes unnecessary API calls #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
rileyjbauer
force-pushed
the
remove-unneeded-getrun-calls
branch
from
2b71d71
to
8cc7486
Compare
|
/lgtm |
From the ExperimentDetails and ExperimentList pages, calls to getRun and getExperiment are removed. From the RunList page, calls to getRun are removed.
rileyjbauer
force-pushed
the
remove-unneeded-getrun-calls
branch
from
8cc7486
to
415a316
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* trying to align versions around k8s 1.18.8 * deps reconcile and need to work through api changes * compiles after updating k8s api calls * move past envtest not liking kustomize * have to explicitly create kfserving-system namespace in tests * tests now passing * instructions for running e2e locally * running e2e on kind * dont change openapi even though generate wants to * pass files to envtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates frontend run API to match backend changes introduced in #1122
From the ExperimentDetails and ExperimentList pages, calls to getRun and
getExperiment are removed.
From the RunList page, calls to getRun are removed.
Related to #149
This change is