Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update types to defined core type names #1206

Merged
merged 1 commit into from
Apr 23, 2019
Merged

update types to defined core type names #1206

merged 1 commit into from
Apr 23, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Apr 23, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 23, 2019

Good catch.
/lgtm

Ark-kun
Ark-kun reviewed Apr 23, 2019
View reviewed changes
components/gcp/dataflow/launch_python/README.md
if __name__ == '__main__':
logging.getLogger().setLevel(logging.INFO)
run()
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a stray change...

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe04254 into kubeflow:master Apr 23, 2019
@gaoning777 gaoning777 deleted the component-dsl-types branch April 23, 2019 20:44
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@pvaneck
[Docs] Add OpenShift installation guide. (kubeflow#1206)
96c6a8f 
These docs cover basic installation of KFServing on OpenShift.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@hougangliu hougangliu Awaiting requested review from hougangliu

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@Ark-kun Ark-kun

@hongye-sun hongye-sun

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaoning777 @Ark-kun @k8s-ci-robot @hongye-sun