Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the auto-generated python SDK docs #1256

Merged
merged 18 commits into from
May 18, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 29, 2019

Adding the Sphinx-based documentation generation.
The documentation files are picked up by the http://readthedocs.org to build the whole documentation website.
The documentation is published at https://kf-pipelines.readthedocs.io/en/latest/source/kfp.html


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 29, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun Ark-kun changed the title [WIP]Added the auto-generated python SDK docs Added the auto-generated python SDK docs Apr 29, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 30, 2019

/test kubeflow-pipeline-e2e-test

@gaoning777
Copy link
Contributor

Please add a readme file about how to use and generate the doc.
Also add the license for the files that are not autogenerated.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 1, 2019

Please add a readme file about how to use and generate the doc.

The docs are built automatically after every master commit.

Also add the license for the files that are not autogenerated.

I've looked at the Google Cloud library and they do not put licenses in the .rst files: https://github.com/googleapis/google-cloud-python/blob/master/storage/docs/buckets.rst

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 1, 2019

Added the licenses

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 1, 2019

Added more information to conf.py

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 1, 2019

Here is the issue to track the setup.py and requirements.txt: #1271

@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 1, 2019

/approve

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 1, 2019

/test kubeflow-pipeline-e2e-test

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 1, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 2, 2019

/test kubeflow-pipeline-e2e-test

@vicaire
Copy link
Contributor

vicaire commented May 3, 2019

Could you please validate with @abhi-g, @paveldournov, @theadactyl that they agree with the choice or readthedocs to store documentation?

@abhi-g
Copy link
Member

abhi-g commented May 3, 2019

/cc @sarahmaddox for opinion on this. I know that we have a bunch of other auto generated documentation that already gets published through Kubeflow website.

@sarahmaddox
Copy link
Contributor

Thanks for pulling me in, @abhi-g. It's best to keep the Kubeflow docs in one place. As you mentioned, we already have auto-generated reference docs on the website:
https://www.kubeflow.org/docs/reference/

To keep the pipelines docs together, we have a reference section under pipelines, where we should add the generated reference docs:
https://www.kubeflow.org/docs/pipelines/reference/

We also have some info on generating the ref docs - we should add the pipelines instructions here too:
https://github.com/kubeflow/website/tree/master/gen-api-reference

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 15, 2019

we have a reference section under pipelines, where we should add the generated reference docs:

Can you add a "proxy" to the documentation website so that the reference docs have kubeflow.org URLs, but are served from elsewhere?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 15, 2019

opensource-licensing had approved the usage of the ReadTheDocs service. /cc @paveldournov

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 16, 2019

/cc @paveldournov


import os
import sys
#sys.path.insert(0, os.path.abspath('.'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can delete?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, paveldournov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, paveldournov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 329e8a5 into kubeflow:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants