Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_pod_env op handler #1540

Merged
merged 5 commits into from
Jul 8, 2019
Merged

add_pod_env op handler #1540

merged 5 commits into from
Jul 8, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Jun 21, 2019

Add default op transformer to inject pod env to op. This transformer will work only when op has label: add-pod-env=true.


This change is Reviewable

sdk/python/kfp/gcp.py Outdated Show resolved Hide resolved
@hongye-sun hongye-sun changed the title Configure gcp connectors in dsl add_pod_env op handler Jul 2, 2019
@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 97ccfd0 into kubeflow:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants