Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini: Add flake8 tests to find Python syntax errors and undefined names #1577

Merged
merged 3 commits into from
Jul 23, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 30, 2019

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @cclauss. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 1, 2019

/lgtm

@cclauss
Copy link
Contributor Author

cclauss commented Jul 16, 2019

Is something more required?

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 17, 2019

/cc @hongye-sun

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: GitHub didn't allow me to request PR reviews from the following users: hon.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongye-sun
Copy link
Contributor

/ok-to-test
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 22, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 41552bd into kubeflow:master Jul 23, 2019
@cclauss cclauss deleted the patch-1 branch July 23, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants