Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete go CLI #1592

Merged
merged 5 commits into from
Jul 19, 2019
Merged

Delete go CLI #1592

merged 5 commits into from
Jul 19, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Jul 3, 2019 •
edited by jlewi
Loading

In favor of the WIP Python CLI
a39ae8e#diff-eae18bc41e1434dd98fa2dd989531da8
/assign @hongye-sun @neuromage @vicaire

This change is Reviewable

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Jul 16, 2019

fix #1632

@IronPan
Copy link
Member Author

IronPan commented Jul 17, 2019

/test kubeflow-pipeline-sample-test

@IronPan IronPan added the lgtm label Jul 19, 2019
@IronPan IronPan merged commit 44712b3 into kubeflow:master Jul 19, 2019
@shenkejie15
Copy link

shenkejie15 commented Aug 20, 2019 •
edited
Loading

May I ask a question that what are the benefits of Python CLI over Go CLI? I am using cobra now and I wonder why you choose Python CLI.

@Ark-kun Ark-kun mentioned this pull request Aug 20, 2019
Closed
@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 20, 2019

May I ask a question that what are the benefits of Python CLI over Go CLI? I am using cobra now and I wonder why you choose Python CLI.

There were some legal hurdles with distributing the compiled binary program, so we never released it in compiled form, which greatly reduced the number of people who could use it.
Also mos of our target users are Python users and our SDK is in python.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@maganaluis
Update Azure Blob to 12.1.0 (kubeflow#1592)
e394be4 
* Update Azure Blob 12.1.0


Removed CONNECTION_STRING env retrieval


correcting tests


re-working mock tests for azure-blob


Corrected some test cases


corrected pytest cases


corrected usage of azure identity


corrected lint errors, test cases

* Corrected Lint Error

* Removed unnecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuromage neuromage Awaiting requested review from neuromage

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@neuromage neuromage

@hongye-sun hongye-sun

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@IronPan @neuromage @k8s-ci-robot @shenkejie15 @Ark-kun @vicaire @hongye-sun