Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/DSL: Fix bug when specifying custom resource for VolumeOp #1595

Merged
merged 1 commit into from Jul 17, 2019

Conversation

elikatsis
Copy link
Member

@elikatsis elikatsis commented Jul 5, 2019

Closes #1593.

Signed-off-by: Ilias Katsakioris elikatsis@arrikto.com


This change is Reviewable

Closes kubeflow#1593.

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
@Ark-kun
Copy link
Contributor

Ark-kun commented Jul 17, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 56e923f into kubeflow:master Jul 17, 2019
@elikatsis elikatsis deleted the fix-vop-custom branch March 9, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crate VolumeOP from k8s_resource error
3 participants