Skip to content

Commit

Permalink
SDK/DSL: Fix bug when specifying custom resource for VolumeOp (#1595)
Browse files Browse the repository at this point in the history
Closes #1593.

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>
  • Loading branch information
elikatsis authored and k8s-ci-robot committed Jul 17, 2019
1 parent d4f2b1e commit 56e923f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sdk/python/kfp/dsl/_volume_op.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def __init__(self,
resource_name: str = None,
size: str = None,
storage_class: str = None,
modes: List[str] = VOLUME_MODE_RWM,
modes: List[str] = None,
annotations: Dict[str, str] = None,
data_source=None,
**kwargs):
Expand Down Expand Up @@ -112,7 +112,7 @@ def __init__(self,
requests={"storage": size}
)
pvc_spec = V1PersistentVolumeClaimSpec(
access_modes=modes,
access_modes=modes or VOLUME_MODE_RWM,
resources=requested_resources,
storage_class_name=storage_class,
data_source=data_source
Expand Down

0 comments on commit 56e923f

Please sign in to comment.