add connection for inverse proxy #1993
Conversation
|
/assign @hongye-sun |
| @@ -96,12 +98,14 @@ def __init__(self, host=None, client_id=None, namespace='kubeflow'): | |||
|
|
|||
| def _load_config(self, host, client_id, namespace): | |||
| config = kfp_server_api.configuration.Configuration() | |||
| host = host or os.environ.get(KF_PIPELINES_ENDPOINT_ENV) | |||
There was a problem hiding this comment.
Is this env variable no longer used?
There was a problem hiding this comment.
Could you help cross check the caller. the original code looks a bit funky to me.
There was a problem hiding this comment.
There was a person who wanted to set entrypoints using env variables (he was probably using shell scripts for automation.).
There was a problem hiding this comment.
that is fine. i pass in self._uihost in caller. should be equavalent.
There was a problem hiding this comment.
the line here is contradict to how we get host in line 90 so can potentially be buggy.
There was a problem hiding this comment.
uihost is read from KF_PIPELINES_UI_ENDPOINT_ENV while the host is read from KF_PIPELINES_ENDPOINT_ENV
There was a problem hiding this comment.
Maybe you just move the host = host or os.environ.get(KF_PIPELINES_ENDPOINT_ENV) up into __init__?
host = host or os.environ.get(KF_PIPELINES_ENDPOINT_ENV)
self._uihost = os.environ.get(KF_PIPELINES_UI_ENDPOINT_ENV, host)
config = self._load_config(host, client_id, namespace)
|
/test kubeflow-pipeline-sample-test |
2 similar comments
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
With this change, user can access the cluster through python with single command
/assign @Ark-kun
This change is