Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script that automatically proxies backend servers for frontend dev server #2104

Merged
merged 5 commits into from Sep 16, 2019

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Sep 13, 2019

When developing frontend against a cluster, use npm run start:proxies to do the following setups automatically.

  • Detect pod names and port forward ml-pipeline and envoy servers
  • Compile and start node backend code in frontend/server that connects with port forwarded servers

Then do npm start to get this

  • Start frontend dev server and let it talk to our node backend

So that, dev env of frontend can talk to real backend and mlmd servers in a real cluster.


This change is Reviewable

@Bobgy Bobgy changed the title Add npm run dev script that automatically proxies both backend and mlmd servers. Add npm run start:all script that automatically proxies both backend and mlmd servers. Sep 16, 2019
@Bobgy Bobgy changed the title Add npm run start:all script that automatically proxies both backend and mlmd servers. Add npm run start:all script that automatically proxies both pipeline api and mlmd servers. Sep 16, 2019
@Bobgy Bobgy changed the title Add npm run start:all script that automatically proxies both pipeline api and mlmd servers. Add npm run start:all script that automatically proxies both pipeline api and metadata servers. Sep 16, 2019
@Bobgy Bobgy changed the title Add npm run start:all script that automatically proxies both pipeline api and metadata servers. Add script that automatically proxies backend servers for frontend dev server Sep 16, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Sep 16, 2019

/assign @IronPan

@IronPan
Copy link
Member

IronPan commented Sep 16, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 16, 2019
@IronPan
Copy link
Member

IronPan commented Sep 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 33f4244 into kubeflow:master Sep 16, 2019
@Bobgy Bobgy deleted the frontend_dev_setup branch September 16, 2019 08:08
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.0.0 to 9.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.0.0...9.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants