Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Python components - Fixed handling multiline decorators #2345

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Oct 9, 2019

Fixes #2335

This change is Reviewable

@Ark-kun Ark-kun force-pushed the SDK---Python-components---Fixed-handling-multiline-decorators branch from b215ee3 to 8c89f2a Compare October 9, 2019 17:36
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 9, 2019

/retest

Also fixed `helper_test_component_against_func_using_local_call`.
@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 15, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 16, 2019

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 16, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit f4d689b into kubeflow:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build_python_component code generator is not correct when the function is decorated with python_component
4 participants