Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Client - Added API models to the generated API #2418

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Oct 16, 2019

The API objects should now be available in the generated client API: kfp.Client().jobs.models.ApiJob.


This change is Reviewable

The API objects should now be available in the generated client API: `kfp.Client().jobs.models.ApiJob`.
@Ark-kun Ark-kun force-pushed the SDK---Client---Added-API-models-to-the-generated-API branch from 639a91e to 59fa34c Compare October 16, 2019 22:52
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 17, 2019

/retest

@Ark-kun Ark-kun force-pushed the SDK---Client---Added-API-models-to-the-generated-API branch from cf18e59 to 7742835 Compare October 17, 2019 19:13
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 18, 2019

/retest

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 18, 2019

/retest

@numerology
Copy link

/lgtm
after solving conflicts.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 1, 2019

@numerology I've fixed the conflict

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 1, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c063a05 into kubeflow:master Nov 2, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: tjandy98 <tjandy98@gmail.com>

Signed-off-by: tjandy98 <tjandy98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants