[UI] Fix metadata tabs loading state #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Yuan. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @Bobgy ! |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…flow#2508) * Remove "default" suffix from generated component name Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com> * Remove "default" from raw deployments Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com> * Fix issues in removing default in raw deployment Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com> * Fixing generating ingress rules for raw deployment Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> * incorporate review comments Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com> --------- Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com> Signed-off-by: Suresh Nakkeran <suresh.n@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2504
Change summary:
metadata UI didn't respect returning a promise when data is ready. I refactored it to use promise now. Therefore, now
CustomTablecan correctly know when loading finishes based on the promise.Screencast: https://drive.google.com/file/d/1Bd4uqh_Da39mEGEvW_Z-gCgTEJqk9agA/view
/cc @numerology
/assign @rmgogogo
/area front-end
/kind bug
This change is