Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib experiment launcher #2577

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Nov 8, 2019

Katib experiment launcher for v1alpha3, which is released in kubeflow 0.7.0


This change is Reviewable

- {name: trialTemplate, type: JSON, description: 'Experiment trialTemplate.'}
- {name: Parameter configs, type: JSON, description: 'Experiment Parameter configuration.'}
- {name: Metrics collector, type: JSON, description: 'Experiment metricsCollector.'}
- {name: Experiment timeout minutes, type: Integer, default: 60*24, description: 'Time in minutes to wait for the Experiment to complete.'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

60*24

I'm not sure this will work as it's not an integer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can work, in fact it is 1 day (1440 min)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid confused, change it to 1440

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can work, in fact it is 1 day (1440 min)

I'm curious. Can you tell be why/how this works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ark-kun sorry to mislead you, when I replied you, I didn't know what component.yaml is used for, I had thought you were asking me if experimentTimeoutMinites works.
Now, I had fixed it and test component.yaml in sample2.py
Thanks

@hougangliu hougangliu force-pushed the katib-experiment branch 4 times, most recently from 2935b19 to d14bad1 Compare November 9, 2019 06:31
@hougangliu
Copy link
Member Author

/test kubeflow-pipeline-sample-test

@hougangliu
Copy link
Member Author

/cc @Tomcli @animeshsingh

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 13, 2019

/lgtm

@hougangliu
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hougangliu
Copy link
Member Author

/test kubeflow-pipeline-sample-test

@k8s-ci-robot k8s-ci-robot merged commit d343607 into kubeflow:master Nov 14, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* make prom metric names consistent

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

* updating docs

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants