Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store ns in db #2698

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Store ns in db #2698

merged 4 commits into from
Dec 5, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Dec 4, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 5, 2019

Does cluster upgrade handle the DB schema upgrade?

@gaoning777
Copy link
Contributor Author

There is no DB schema changes. It is totally backward compatible.

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 5, 2019

There is no DB schema changes. It is totally backward compatible.

That's great

Bobgy
Bobgy reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick change!
/lgtm

backend/src/apiserver/storage/resource_reference_store.go Show resolved Hide resolved
@gaoning777 gaoning777 assigned IronPan and unassigned IronPan and Bobgy Dec 5, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 5, 2019
@IronPan
Copy link
Member

IronPan commented Dec 5, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a68feed into kubeflow:master Dec 5, 2019
@gaoning777 gaoning777 deleted the store-ns-in-db branch December 5, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy left review comments

@IronPan IronPan Awaiting requested review from IronPan

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

Assignees

@IronPan IronPan

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaoning777 @Ark-kun @IronPan @k8s-ci-robot @Bobgy