Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make created_at value follows RFC3339 time format. #2876

Merged
merged 6 commits into from
Jan 30, 2020
Merged

Make created_at value follows RFC3339 time format. #2876

merged 6 commits into from
Jan 30, 2020

Conversation

jiyongjung0
Copy link
Contributor

@jiyongjung0 jiyongjung0 commented Jan 20, 2020 •
edited by jlewi
Loading

Make created_at value of default_version in UploadPiplineResponse follow RFC3339 time format.

It returned created_at value as a json dictionary, for example
"created_at":{"seconds":1576824474}, and broke SDK parser. jsonpb
will be used to take care of all json marshaling including time format
conversion.

See #2764 for the detail.

This change is Reviewable

Make created_at value of default_version in UploadPiplineResponse fol…
865e53f 
…low RFC3339 time format.

It returned `created_at` value as a json dictionary, for example
`"created_at":{"seconds":1576824474}`, and broke SDK parser.  `jsonpb`
will be used to take care of all json marshaling including time format
conversion.

See #2764 for the detail.
@k8s-ci-robot
Copy link
Contributor

Hi @jiyongjung0. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Jiyong Jung added 3 commits January 20, 2020 15:36
Make created_at value of default_version in UploadPiplineResponse fol…
73a115d 
…low RFC3339 time format.

It returned `created_at` value as a json dictionary, for example
`"created_at":{"seconds":1576824474}`, and broke SDK parser.  `jsonpb`
will be used to take care of all json marshaling including time format
conversion.

See #2764 for the detail.
Set jsonpb marshaler to output ints for enums.
d03e4fa
Merge branch 'master' of https://github.com/jiyongjung0/pipelines
5c58454
@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 22, 2020

/ok-to-test

@neuromage
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiyongjung0
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 77a3553 into kubeflow:master Jan 30, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@jiyongjung0 @Jeffwan
Make created_at value follows RFC3339 time format. (kubeflow#2876)
8182bd6 
* Make created_at value of default_version in UploadPiplineResponse follow RFC3339 time format.

It returned `created_at` value as a json dictionary, for example
`"created_at":{"seconds":1576824474}`, and broke SDK parser.  `jsonpb`
will be used to take care of all json marshaling including time format
conversion.

See kubeflow#2764 for the detail.

* Make created_at value of default_version in UploadPiplineResponse follow RFC3339 time format.

It returned `created_at` value as a json dictionary, for example
`"created_at":{"seconds":1576824474}`, and broke SDK parser.  `jsonpb`
will be used to take care of all json marshaling including time format
conversion.

See kubeflow#2764 for the detail.

* Set jsonpb marshaler to output ints for enums.

* Parse json response to check formatting of the `created_at` field.

* Lint: reformatted comments.
@jiyongjung0 jiyongjung0 mentioned this pull request Feb 7, 2022
Merged
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@cmaddalozzo @yuzisun
Make postprocess interface consistent with V2 protocol (kubeflow#2876)
184820f 
* Make postprocess interface consistent with V2 protocol

Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>

* fix request argument name

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

---------

Signed-off-by: Curtis Maddalozzo <cmaddalozzo@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Ark-kun left review comments

@jingzhang36 jingzhang36 Awaiting requested review from jingzhang36

@neuromage neuromage Awaiting requested review from neuromage

@IronPan IronPan Awaiting requested review from IronPan

@rmgogogo rmgogogo Awaiting requested review from rmgogogo

Assignees

@neuromage neuromage

@rmgogogo rmgogogo

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jiyongjung0 @k8s-ci-robot @Ark-kun @neuromage @rmgogogo