[Testing] Reduce flakiness caused by iam bindings #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: numerology The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test kubeflow-pipeline-sample-test |
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
* Add retry to iam policy bindings * Add retry for iam policy changes to reduce flakiness
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* add status conditions for service readiness of each component Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add PropagateServiceReadyStatus() Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * propagate ServiceReady status in all components Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix naming and comments Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * reconcile ServiceReady status Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * rename inferenceServiceReadiness() -> isvcLatestRevisionReadiness() Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * remove previous logic for ServiceReady status aggregation Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * modify ServiceReady propagation in controller Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * only set ServiceReady status for serverless deployment Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add serverless deployment mode and RoutesReady conditions for test components Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix naming typo Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * rename ServiceReady status to RoutesReady Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * remove PredictorReady from living condition set Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add LatestDeploymentReady status and function to propagate cross-component status conditions Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * remove incorrect condition type Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * add ConfigurationsReady and LatestDeploymentReady to tests Signed-off-by: Tessa Pham <hpham111@bloomberg.net> * fix naming Signed-off-by: Tessa Pham <hpham111@bloomberg.net> --------- Signed-off-by: Tessa Pham <hpham111@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @Ark-kun
This change is