Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visualizations for Schema and ExampleAnomalies #3026

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Add visualizations for Schema and ExampleAnomalies #3026

merged 4 commits into from
Feb 12, 2020

Conversation

Realsen
Copy link
Contributor

@Realsen Realsen commented Feb 10, 2020 •
edited by jlewi
Loading

This completes the work to visualize TFDV artifacts - TFMA artifacts still need to be investigated further.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Realsen. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bobgy
Bobgy reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks! Only left some minor comments. Feel free to ask anyone to lgtm after you fix them.

frontend/src/lib/OutputArtifactLoader.ts Outdated Show resolved Hide resolved
frontend/src/lib/OutputArtifactLoader.ts Outdated Show resolved Hide resolved
@Realsen
Copy link
Contributor Author

Realsen commented Feb 10, 2020

/assign @neuromage

@neuromage
Copy link
Contributor

/lgtm
/retest

@neuromage
Copy link
Contributor

/ok-to-test

@Realsen
Copy link
Contributor Author

Realsen commented Feb 11, 2020

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 11, 2020
@Realsen
Copy link
Contributor Author

Realsen commented Feb 11, 2020

/retest

1 similar comment
@Realsen
Copy link
Contributor Author

Realsen commented Feb 11, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neuromage
Copy link
Contributor

/lgtm

@Realsen Realsen merged commit 89846ef into kubeflow:master Feb 12, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
@Realsen @Jeffwan
Add visualizations for Schema and ExampleAnomalies (kubeflow#3026)
7d77ada 
* Add visualizations for Schema and ExampleAnomalies

* Run npm format

* Fix compile warnings

* Address PR comments
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@tessapham
put back PredictorReady in living condition set (kubeflow#3026)
8e51531 
* put back PredictorReady in living condition set

Signed-off-by: Tessa Pham <hpham111@bloomberg.net>

* fix comments

Signed-off-by: Tessa Pham <hpham111@bloomberg.net>

---------

Signed-off-by: Tessa Pham <hpham111@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobgy Bobgy Bobgy left review comments

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@neuromage neuromage

Labels
approved lgtm ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Realsen @k8s-ci-robot @neuromage @Bobgy