Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Upload pipeline version from local package #3059

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Feb 12, 2020

UI of #2977
demo: https://youtu.be/3dLjggHFqxg

TODO: add unit tests

/assign @jingzhang36
/area frontend
/priority p0
/kind feature


This change is Reviewable

@jingzhang36
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 12, 2020
@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 12, 2020

/retest

@rmgogogo
Copy link
Contributor

/retest

the demo seems great. not sure whether can submit before Jing's cut.

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 12, 2020

/retest
Cloudbuild failures seem unrelated to this PR

@jingzhang36
Copy link
Contributor

jingzhang36 commented Feb 13, 2020

/retest
/lgtm

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 13, 2020

/retest

@Bobgy
Copy link
Contributor Author

Bobgy commented Feb 13, 2020

/approve

1 similar comment
@rmgogogo
Copy link
Contributor

/approve

@rmgogogo
Copy link
Contributor

/lgtm

@jingzhang36
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, jingzhang36, rmgogogo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy Bobgy merged commit 946a29c into kubeflow:master Feb 13, 2020
@Bobgy Bobgy deleted the fe_upload_version_local branch February 13, 2020 08:06
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* [UI] Upload pipeline version from local package

* Fix test error

* Improve broken license file
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants