Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 0.2.4 and tiny BTW doc fix #3115

Merged
merged 6 commits into from
Feb 19, 2020
Merged

bump version to 0.2.4 and tiny BTW doc fix #3115

merged 6 commits into from
Feb 19, 2020

Conversation

rmgogogo
Copy link
Contributor

@rmgogogo rmgogogo commented Feb 19, 2020

bump version to 0.2.4 and tiny BTW doc fix


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Feb 19, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@@ -6,7 +6,7 @@
},
{
"name": "[Demo] TFX - Taxi Tip Prediction Model Trainer",
"description": "[source code](https://console.cloud.google.com/mlengine/notebooks/deploy-notebook?q=download_url%3Dhttps%253A%252F%252Fraw.githubusercontent.com%252Fkubeflow%252Fpipelines%252Fmaster%252Fsamples%252Fcore%252Fparameterized_tfx_oss%252Ftaxi_pipeline_notebook.ipynb) [GCP Permission requirements](https://github.com/kubeflow/pipelines/blob/master/samples/contrib/parameterized_tfx_oss#permission). Example pipeline that does classification with model analysis based on a public tax cab dataset.",
"description": "[source code](https://github.com/kubeflow/pipelines/tree/master/samples/core/parameterized_tfx_oss) [GCP Permission requirements](https://github.com/kubeflow/pipelines/blob/master/samples/contrib/parameterized_tfx_oss#permission). Example pipeline that does classification with model analysis based on a public tax cab dataset.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SinaChavoshi @Bobgy
FYI, I correct the source code link to github link, not the link to CAIP notebook

@rmgogogo
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 23e9d37 into kubeflow:master Feb 19, 2020
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* update guide for cluster size

* bump version to 0.2.4

* remove ALPHA

* update sample source link

* fix snapshot

* done

Co-authored-by: renmingu <40223865+renmingu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants