Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formating jsonnet registry #333

Merged
merged 5 commits into from
Nov 20, 2018
Merged

formating jsonnet registry #333

merged 5 commits into from
Nov 20, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 20, 2018

This would be consistent with kubeflow's repo
kubeflow/kubeflow@611e523

This is the tool used to formatting the code
https://github.com/kubeflow/kubeflow/blob/master/scripts/autoformat_jsonnet.sh


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 20, 2018

/assign @gaoning777

@IronPan
Copy link
Member Author

IronPan commented Nov 20, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@IronPan
Copy link
Member Author

IronPan commented Nov 20, 2018

/test build-image

Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 32013a1 into master Nov 20, 2018
@IronPan IronPan deleted the yangpa/format branch December 10, 2018 22:26
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants