[WIP] Add notebook sample test #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gaoning777
requested review from
qimingj
and removed request for
Ark-kun and
IronPan
gaoning777
force-pushed
the
ngao/notebook-sample-test
branch
from
ae4a87d
to
98a1750
Compare
gaoning777
force-pushed
the
ngao/notebook-sample-test
branch
from
98a1750
to
fb8bad7
Compare
|
solving #263 |
|
/test presubmit-unit-test |
|
/test presubmit-sample-test |
…, fix minor bugs add CMLE model deletion
|
/test presubmit-sample-test |
…r model name and version
|
/retest |
1 similar comment
|
/retest |
|
/test presubmit-sample-test |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* We weren't properly paginating through the results; we need to reset
nextPageToken when switching zones
* Due to this bug cleanup_disks wasn't actually being called we were just
error'ing out and cleanup_ci was ignoring this error.
* We weren't calling execute on the delete request
* We needed more regexes to match disks to be deleted.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…and unified predictor concept with explainer/transformer (kubeflow#397) * Fixes issues with Validation not applying to transformers/explainers * Added Validation classes * more changes * Standardized terminology around predictors * Renames * Added predictor * other renames and fixes * adding swagger * Moved more validation logic to predictor * Fixed validation * Fixed validation * Fixed configmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is