-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add notebook sample test #397
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ae4a87d
to
98a1750
Compare
98a1750
to
fb8bad7
Compare
solving #263 |
/test presubmit-unit-test |
/test presubmit-sample-test |
…, fix minor bugs add CMLE model deletion
/test presubmit-sample-test |
…r model name and version
/retest |
1 similar comment
/retest |
/test presubmit-sample-test |
* We weren't properly paginating through the results; we need to reset nextPageToken when switching zones * Due to this bug cleanup_disks wasn't actually being called we were just error'ing out and cleanup_ci was ignoring this error. * We weren't calling execute on the delete request * We needed more regexes to match disks to be deleted.
…and unified predictor concept with explainer/transformer (kubeflow#397) * Fixes issues with Validation not applying to transformers/explainers * Added Validation classes * more changes * Standardized terminology around predictors * Renames * Added predictor * other renames and fixes * adding swagger * Moved more validation logic to predictor * Fixed validation * Fixed validation * Fixed configmap
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)