Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added presubmit unit tests for the GCP components #4137

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jul 2, 2020

Description of your changes:

Checklist:

  • The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

    PR titles examples:

    • fix(frontend): fixes empty page. Fixes #1234
      Use fix to indicate that this PR fixes a bug.
    • feat(backend): configurable service account. Fixes #1234, fixes #1235
      Use feat to indicate that this PR adds a new feature.
    • chore: set up changelog generation tools
      Use chore to indicate that this PR makes some changes that users don't need to know.
    • test: fix CI failure. Part of #1234
      Use part of to indicate that a PR is working on an issue, but shouldn't close the issue when merged.
  • Do you want this pull request (PR) cherry-picked into the current release branch?

    If yes, use one of the following options:

    • (Recommended.) Ask the PR approver to add the cherrypick-approved label to this PR. The release manager adds this PR to the release branch in a batch update.
    • After this PR is merged, create a cherry-pick PR to add these changes to the release branch. (For more information about creating a cherry-pick PR, see the Kubeflow Pipelines release guide.)

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubeflow-bot
Copy link

This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 2, 2020

/test kubeflow-pipelines-components-gcp-python27

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 2, 2020

/test kubeflow-pipelines-components-gcp-python37

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 2, 2020

/test kubeflow-pipelines-components-gcp-python27
/test kubeflow-pipelines-components-gcp-python37

@Ark-kun Ark-kun marked this pull request as ready for review July 2, 2020 06:50
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 2, 2020

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 2, 2020

/retest

1 similar comment
@Bobgy
Copy link
Contributor

Bobgy commented Jul 2, 2020

/retest

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 11, 2020

Gentle ping.

@Bobgy
Copy link
Contributor

Bobgy commented Jul 12, 2020

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jul 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bdb12c1 into kubeflow:master Jul 15, 2020
@Bobgy Bobgy added cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` labels Sep 4, 2020
Bobgy pushed a commit to Bobgy/pipelines that referenced this pull request Sep 4, 2020
* Testing - Added presubmit unit tests for the GCP components

* Added more versions and skip_missing_interpreters=true to tox.ini
Bobgy pushed a commit to Bobgy/pipelines that referenced this pull request Sep 4, 2020
* Testing - Added presubmit unit tests for the GCP components

* Added more versions and skip_missing_interpreters=true to tox.ini
Bobgy pushed a commit to Bobgy/pipelines that referenced this pull request Sep 4, 2020
* Testing - Added presubmit unit tests for the GCP components

* Added more versions and skip_missing_interpreters=true to tox.ini
Bobgy pushed a commit that referenced this pull request Sep 4, 2020
* Testing - Added presubmit unit tests for the GCP components

* Added more versions and skip_missing_interpreters=true to tox.ini
Jeffwan pushed a commit to Jeffwan/pipelines that referenced this pull request Dec 9, 2020
* Testing - Added presubmit unit tests for the GCP components

* Added more versions and skip_missing_interpreters=true to tox.ini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/testing cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants