Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Components - Fixed python components that use \n. Fixes #4939 #4985

Closed

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jan 13, 2021

The escape sequence was being replaced by the echo command.

Apparently, unlike in the bash shell, the echo command of the sh shell expands the escape sequences by default and does not support an option to turn it off. (For some reason the -n option works properly even though it should not).

Fixes #4939

The escape sequence was being replaced by the `echo` command.

Apparently, unlike in the `bash` shell, the `echo` command of the `sh` shell expands the escape sequences by default and does not support an option to turn it off. (For some reason the -n option works properly even though it should not).

Fixes #4939
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Jan 13, 2021

/lgtm
thanks for the quick fix!

@Bobgy
Copy link
Contributor

Bobgy commented Jan 13, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-sample-test ff7c1fb link /test kubeflow-pipeline-sample-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 13, 2021

@google-oss-robot
Copy link

@Ark-kun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test ff7c1fb link /test kubeflow-pipeline-e2e-test
kubeflow-pipeline-sample-test ff7c1fb link /test kubeflow-pipeline-sample-test
kubeflow-pipeline-upgrade-test ff7c1fb link /test kubeflow-pipeline-upgrade-test
kubeflow-pipelines-tfx-python36 ff7c1fb link /test kubeflow-pipelines-tfx-python36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Bobgy Bobgy closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape sequence bug in func_to_container_op
6 participants