Update WORKSPACE and BUILD files incoporating recent changes #639
Conversation
change. That change was submitted in parallel with the PR that moved everything to Bazel and so wasn't included. Along the way, fix conflicts in imports that was using controller-runtime library. We can import it either through github.com/kubernetes-sigs or sigs.k8s.io/controller-runtime, but shouldn't be using both imports, which was causing conflicts at build time.
|
We should probably also make Bazel build and test everything as part of Travis. I'll look into doing that. |
|
/lgtm |
|
@neuromage Does Prow tests need to be updated too? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not necessary. #640 will add it as part of Travis. We still want |
* Go builds of started to break and this appears to be due to the use of 1.12. * See kubeflow/manifests#1104 * See kubeflow/kfctl#306 * New image is gcr.io/kubeflow-ci/test-worker-py3:e9afed1-dirty
In particular, fix it for the change in #449 which introduced more dependencies from using the controller-runtime Kubernetes library. That change was submitted in parallel with the PR that moved everything to Bazel and so wasn't included.
Along the way, fix conflicts in imports that was using
controller-runtime library. We can import it either through
github.com/kubernetes-sigs or sigs.k8s.io/controller-runtime, but
shouldn't be using both imports, which was causing conflicts at build
time.
Fixes #638
This change is