Include date in run status tooltips #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test kubeflow-pipeline-build-image |
1 similar comment
|
/test kubeflow-pipeline-build-image |
…nd CI test environments
rileyjbauer
force-pushed
the
include-date-in-run-status-tooltips
branch
from
dcdfed4
to
25e1b81
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yebrahim
reviewed
Jan 15, 2019
| @@ -34,6 +35,9 @@ describe('ExperimentList', () => { | |||
| const historyPushSpy = jest.fn(); | |||
| const listExperimentsSpy = jest.spyOn(Apis.experimentServiceApi, 'listExperiment'); | |||
| const listRunsSpy = jest.spyOn(Apis.runServiceApi, 'listRuns'); | |||
| // We mock this because it uses toLocaleDateString, which causes mismatches between local and CI | |||
|
/test kubeflow-pipeline-build-image |
|
Does this fix #61? |
Nice catch. Yes it does, although the tooltips are not fully aligned with the ones Ajay provided in that issue. It is probably fine to close the issue regardless, and I can touch them up in a follow-up |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExperimentListwill now show the run's start date.RunDetailspage shows start date.This change is