test(sdk): implement small tests for Client class #8517
Conversation
Co-authored-by: droctothorpe <mythicalsunlight@gmail.com>
|
Hi @andreafehrman. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| def get_kfp_healthz(self) -> kfp_server_api.ApiGetHealthzResponse: | ||
| def get_kfp_healthz( | ||
| self, | ||
| sleep_duration: int = 5) -> kfp_server_api.ApiGetHealthzResponse: |
There was a problem hiding this comment.
Without this parameter, this small test takes 15 seconds to execute due to the 5 second default. We default it to 5 so there is no change to end users from a UX/API standpoint.
There was a problem hiding this comment.
/lgtm
/approve
@andreafehrman and @droctothorpe, thank you so much for helping improve the tests!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Woohoo! Thanks for the rapid review, @chensun! 🥳 |
|
Thanks so much for reviewing @chensen!! |
Co-authored-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: droctothorpe <mythicalsunlight@gmail.com>
Co-authored-by: droctothorpe mythicalsunlight@gmail.com
Description of your changes:
This PR (in response to this issue) implements small tests for various methods in
Client, providing 51% coverage. This includes tests forwait_for_run_completion,_is_ipython,get_experiment,create_experiment, andget_kfp_healthz. Functions that just make pass through calls to the Python HTTP client have been avoided.We are very open to any feedback so let us know if there are any additional requirements.
Checklist: